Set error status if http has exception and ok status. (#1143)

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
getsentry · Jul 27, 2021 · b551e59 · b551e59
1 parent b08a831
commit b551e59
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,8 +2,9 @@
 
 ## Unreleased
 
-## Fixes
+### Fixes
 
+- Set error status to transaction if http has exception and ok status ([#1143](https://github.com/getsentry/sentry-dotnet/pull/1143))
 - Fix max breadcrumbs limit when MaxBreadcrumbs is zero or lower ([#1145](https://github.com/getsentry/sentry-dotnet/pull/1145))
 
 ## 3.8.3

diff --git a/src/Sentry.AspNetCore/SentryTracingMiddleware.cs b/src/Sentry.AspNetCore/SentryTracingMiddleware.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Runtime.ExceptionServices;
 using System.Threading.Tasks;
@@ -157,6 +157,13 @@ public async Task InvokeAsync(HttpContext context)
                     {
                         transaction.Finish(status);
                     }
+                    // Status code not yet changed to 500 but an exception does exist
+                    // so lets avoid passing the misleading 200 down and close only with
+                    // the exception instance that will be inferred as errored.
+                    else if (status == SpanStatus.Ok)
+                    {
+                        transaction.Finish(exception);
+                    }
                     else
                     {
                         transaction.Finish(exception, status);

diff --git a/test/Sentry.AspNetCore.Tests/SentryTracingMiddlewareTests.cs b/test/Sentry.AspNetCore.Tests/SentryTracingMiddlewareTests.cs
@@ -1,4 +1,4 @@
-#if !NETCOREAPP2_1
+#if !NETCOREAPP2_1
 using System;
 using System.Collections.Generic;
 using System.Net.Http;
@@ -338,7 +338,8 @@ public async Task Transaction_binds_exception_thrown()
             await client.GetAsync("/person/13");
 
             // Assert
-            Assert.True(hub.ExceptionToSpanMap.TryGetValue(exception, out _));
+            Assert.True(hub.ExceptionToSpanMap.TryGetValue(exception, out var span));
+            Assert.Equal(SpanStatus.InternalError, span.Status);
         }
     }
 }