Merge branch 'feat/4.0.0' into chore/cleanup-stackframe-attributes-v4

getsentry · Oct 3, 2023 · c55e0fe · c55e0fe
2 parents 5c89c0f + ede4a04
commit c55e0fe
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,6 +24,7 @@ API Changes:
 - Adding `Distribution` to `IEventLike` ([#2660](https://github.com/getsentry/sentry-dotnet/pull/2660))
 - Removed unused `StackFrame.InstructionOffset`. ([#2691](https://github.com/getsentry/sentry-dotnet/pull/2691))
 - Change `StackFrame`'s `ImageAddress`, `InstructionAddress` and `FunctionId` to `long?`. ([#2691](https://github.com/getsentry/sentry-dotnet/pull/2691))
+- Enable `CaptureFailedRequests` by default ([2688](https://github.com/getsentry/sentry-dotnet/pull/2688))
 
 ## Unreleased
 

diff --git a/src/Sentry/SentryOptions.cs b/src/Sentry/SentryOptions.cs
@@ -664,7 +664,7 @@ public bool ReportAssemblies
     /// <para>Also <see cref="FailedRequestTargets"/> can be used to filter to match only certain request URLs.</para>
     /// <para>Defaults to false due to PII reasons.</para>
     /// </summary>
-    public bool CaptureFailedRequests { get; set; }
+    public bool CaptureFailedRequests { get; set; } = true;
 
     /// <summary>
     /// <para>The SDK will only capture HTTP Client errors if the HTTP Response status code is within these defined ranges.</para>

diff --git a/test/Sentry.Tests/SentryOptionsTests.cs b/test/Sentry.Tests/SentryOptionsTests.cs
@@ -175,10 +175,10 @@ public void IsPerformanceMonitoringEnabled_EnableTracing_False_TracesSampler_Pro
     }
 
     [Fact]
-    public void CaptureFailedRequests_ByDefault_IsFalse()
+    public void CaptureFailedRequests_ByDefault_IsTrue()
     {
         var sut = new SentryOptions();
-        Assert.False(sut.CaptureFailedRequests, "CaptureFailedRequests should be false by default to protect potentially PII (Privately Identifiable Information)");
+        Assert.True(sut.CaptureFailedRequests);
     }
 
     [Fact]