Save Scope rather than Scope.Clone

getsentry · Oct 9, 2023 · d189a78 · d189a78
1 parent 9fb54a5
commit d189a78
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Sentry.AspNetCore/SentryMiddleware.cs b/src/Sentry.AspNetCore/SentryMiddleware.cs
@@ -137,7 +137,7 @@ public async Task InvokeAsync(HttpContext context, RequestDelegate next)
                 {
                     // The middleware pipeline finishes up before the Otel Activity.OnEnd callback is invoked so we need
                     // so save a copy of the scope that can be restored by our SentrySpanProcessor
-                    hub.ConfigureScope(scope => activity.SetFused(scope.Clone()));
+                    hub.ConfigureScope(scope => activity.SetFused(scope));
                 }
 
                 // When an exception was handled by other component (i.e: UseExceptionHandler feature).

diff --git a/test/Sentry.AspNetCore.Tests/SentryMiddlewareTests.cs b/test/Sentry.AspNetCore.Tests/SentryMiddlewareTests.cs
@@ -675,7 +675,7 @@ public async Task InvokeAsync_InstrumenterOpenTelemetry_SavesScope()
             await sut.InvokeAsync(_fixture.HttpContext, _fixture.RequestDelegate);
 
             // Assert
-            activity.GetFused<Scope>().Should().NotBeNull();
+            activity.GetFused<Scope>().Should().Be(scope);
         }
         finally
         {