Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to suppress "Ignoring request with Size null and configuration RequestSize Always" message #1220

Closed
11 tasks
shones34 opened this issue Sep 28, 2021 · 1 comment · Fixed by #1348
Closed
11 tasks
Labels
Feature New feature or request

Comments

@shones34
Copy link

shones34 commented Sep 28, 2021

Please mark the type framework used:

  • ASP.NET MVC
  • ASP.NET Web API (OWIN)
  • [ X ] ASP.NET Core
  • WPF
  • WinForms
  • Xamarin
  • Other:

Please mark the type of the runtime used:

  • .NET Framework
  • Mono
  • [ X ] .NET Core
  • Version:

Please mark the NuGet packages used:

  • [ X ] Sentry
  • [ X ] Sentry.Serilog
  • Sentry.NLog
  • Sentry.Log4Net
  • Sentry.Extensions.Logging
  • [ X ] Sentry.AspNetCore
  • Version: 3.8.3

Hello, I have enabled the "MaxRequestBodySize": "Always" property and am constantly getting warnings for requests which are null.

Sentry config:

"Sentry": {
    "Dsn": XXX,
    "MaxRequestBodySize": "Always",
    "SendDefaultPii": true,
    "MinimumBreadcrumbLevel": "Debug",
    "MinimumEventLevel": "Warning", 
    "AttachStackTrace": true,
    "Debug": false,
    "DiagnosticsLevel": "Error"
  }

Is there a way to suppress the warning so that I do not see this noise on every call with a null request?

image

@bruno-garcia
Copy link
Member

We could skip this log entry altogether in case it's null. It's only null with requests that don't have body so no big deal. Is this something you could contribute with a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants