Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont log Ignoring request with Size null #1348

Merged
merged 6 commits into from
Nov 25, 2021

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Nov 24, 2021

fixes #1220

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #1348 (405b9ff) into main (3d186db) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 405b9ff differs from pull request most recent head baf3abb. Consider uploading reports for the commit baf3abb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1348      +/-   ##
==========================================
+ Coverage   82.61%   82.64%   +0.02%     
==========================================
  Files         215      215              
  Lines        7146     7145       -1     
  Branches     1406     1407       +1     
==========================================
+ Hits         5904     5905       +1     
+ Misses        808      806       -2     
  Partials      434      434              
Impacted Files Coverage Δ
...etCore.Grpc/ProtobufRequestExtractionDispatcher.cs 0.00% <ø> (ø)
...y/Extensibility/RequestBodyExtractionDispatcher.cs 96.29% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d186db...baf3abb. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@SimonCropp SimonCropp merged commit c0c7e39 into main Nov 25, 2021
@SimonCropp SimonCropp deleted the dont-log-Ignoring-request-with-Size-null branch November 25, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to suppress "Ignoring request with Size null and configuration RequestSize Always" message
4 participants