dont log Ignoring request with Size null (#1348)

getsentry · Nov 25, 2021 · c0c7e39 · c0c7e39
1 parent 3d186db
commit c0c7e39
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 ### Features
 
+- Dont log "Ignoring request with Size" when null ([#1348](https://github.com/getsentry/sentry-dotnet/pull/1348))
 - Move to stable v6 for `Microsoft.Extensions.*` packages ([#1347](https://github.com/getsentry/sentry-dotnet/pull/1347))
 
 ### Fixes

diff --git a/src/Sentry.AspNetCore.Grpc/ProtobufRequestExtractionDispatcher.cs b/src/Sentry.AspNetCore.Grpc/ProtobufRequestExtractionDispatcher.cs
@@ -72,9 +72,6 @@ public ProtobufRequestExtractionDispatcher(IEnumerable<IProtobufRequestPayloadEx
                 return null;
         }
 
-        _options.Log(SentryLevel.Warning,
-            "Ignoring request with Size {0} and configuration RequestSize {1}", null, request.ContentLength, size);
-
         return null;
     }
 }
diff --git a/src/Sentry/Extensibility/RequestBodyExtractionDispatcher.cs b/src/Sentry/Extensibility/RequestBodyExtractionDispatcher.cs
@@ -70,8 +70,11 @@ public RequestBodyExtractionDispatcher(IEnumerable<IRequestPayloadExtractor> ext
                     return null;
             }
 
-            _options.LogWarning("Ignoring request with Size {0} and configuration RequestSize {1}",
-                request.ContentLength, size);
+            if (request.ContentLength is not null)
+            {
+                _options.LogWarning("Ignoring request with Size {0} and configuration RequestSize {1}",
+                    request.ContentLength, size);
+            }
 
             return null;
         }