Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Unknown Route" with the raw URL and a transaction annotation #1786

Closed
bruno-garcia opened this issue Jul 19, 2022 · 4 comments · Fixed by #1919 or #1968
Closed

Replace "Unknown Route" with the raw URL and a transaction annotation #1786

bruno-garcia opened this issue Jul 19, 2022 · 4 comments · Fixed by #1919 or #1968
Labels
Feature New feature or request Product: Tracing

Comments

@bruno-garcia
Copy link
Member

Problem Statement

The spec now allows to send raw URLs when they are annotated so the server can take that into account:

https://develop.sentry.dev/sdk/event-payloads/transaction/#transaction-annotations

Solution Brainstorm

We can rely on that and replace the current "Unknown Route" sent by the ASP.NET Core integration which isn't very helpful.

This is a change worthy of landing on the next major. Since a lot of new transactions will show up in Sentry. Today they'd be grouped under one things and going forward they'd rely on Sentry's ability to group them well (even though it'll be based on heuristics)

@mattjohnsonpint
Copy link
Contributor

So, we should send only route when we have it, but otherwise send url and don't send "unknown route" ever.

@mattjohnsonpint
Copy link
Contributor

I think we can do this without waiting for 4.x, but we should note the behavior change in the changelog.

@mattjohnsonpint
Copy link
Contributor

mattjohnsonpint commented Jul 20, 2022

Note, this change will be visible to almost everyone that uses .UseSentryTracing() in ASP.Net Core for performance monitoring, as it will stop grouping 404s in the same way.

@SimonCropp
Copy link
Contributor

@bruno-garcia any thoughts on the comment from @mattjohnsonpint ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Product: Tracing
Projects
Archived in project
3 participants