Use URL path in transaction names instead of "Unknown Route" #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjohnsonpint
commented
Sep 15, 2022
Comment on lines
+26
to
+27
| Name: OPTIONS /Target, | ||
| NameSource: Url, |
There was a problem hiding this comment.
Note, that this essentially would handle #1835, except that we've decided to no longer sent pre-flight requests. The work to remove such transactions will come separately by @SimonCropp.
SimonCropp
reviewed
Sep 15, 2022
SimonCropp
approved these changes
Sep 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have
TransactionNameSource(see #1910), we no longer need to send "Unknown Route" if we can't identify the route for a web request. Instead, we'll use the URL path, and setTransactionNameSource.Url.Also, if the route is set via
SentryAspNetCoreOptions.TransactionNameProvider, then we'll continue to use that - but will setTransactionNameSource.Custom.Only when we've actually got a route should we set
TransactionNameSource.Route.