You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So if you don't have any excludes configured or if the namespace doesn't match one of more of the prefixes configured as an exclude then frame is determined as InApp. This seems way too greedy. That means if you have no includes configured but you have these excludes configured:
- Foo
- Bar
Then the namespace Bar will be considered InApp (because it doesn't match Foo). Given there's an explicit exclude configured for Bar, this seems counter-intuitive. I think there's a bug in this logic then.
The logic should instead be "If it matches any of the Includes and it doesn't match any of the excludes, then it's InApp".
Solution Brainstorm
If SentryOptions.InAppInclude and SentryOptions.InAppExclude were lists of SubstringOrRegex rather than just lists of prefixes, it would be possible to configure an Exclude of .*... which would enable the customer to do what they want.
We also need to fix the logic for matching exclusions from "doesn't match any single exclusion" to "doesn't match any exclusion".
The text was updated successfully, but these errors were encountered:
Problem Statement
One of our customers wants to be able to simply add their own namespace as an include and exclude everything else (see Discord thread).
Currently this doesn't work as the logic to determine whether a frame is InApp or not is:
sentry-dotnet/src/Sentry/SentryStackFrame.cs
Line 218 in 5fab09e
So if you don't have any excludes configured or if the namespace doesn't match one of more of the prefixes configured as an exclude then frame is determined as InApp. This seems way too greedy. That means if you have no includes configured but you have these excludes configured:
Then the namespace
Bar
will be considered InApp (because it doesn't matchFoo
). Given there's an explicit exclude configured forBar
, this seems counter-intuitive. I think there's a bug in this logic then.The logic should instead be "If it matches any of the Includes and it doesn't match any of the excludes, then it's InApp".
Solution Brainstorm
If
SentryOptions.InAppInclude
andSentryOptions.InAppExclude
were lists ofSubstringOrRegex
rather than just lists of prefixes, it would be possible to configure an Exclude of.*
... which would enable the customer to do what they want.We also need to fix the logic for matching exclusions from "doesn't match any single exclusion" to "doesn't match any exclusion".
The text was updated successfully, but these errors were encountered: