Regular expressions can now be used for InApp includes/excludes #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...Sentry.Tests/Internals/SentryStackTraceFactoryTests.MethodGeneric_mode=Enhanced.verified.txt
Outdated
Show resolved
Hide resolved
bitsandfoxes
previously approved these changes
Apr 24, 2024
vaind
requested changes
Apr 25, 2024
vaind
reviewed
Apr 26, 2024
test/Sentry.Profiling.Tests/TraceLogProcessorTests.ProfileInfo_Serialization_Works.verified.txt
Show resolved
Hide resolved
vaind
reviewed
May 2, 2024
There was a problem hiding this comment.
It's a bit more complicated solution than what I had in mind in my proposal (albeit more flexible too, I guess), but as long as the performance is OK, I'm fine with that. Have you checked the original vs current version in benchmarks manually? Can you please post the results?
@vaind the newer code was actually significantly slower (~40%) so I've tightened it up a bit and now I'm seeing: main branch
inapp-regex branch
Which is cool... now it's way faster and allocates way less memory 🥳 I think most of those gains were simply getting rid of Linq, although I did get rid of another lambda as well. |
vaind
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3158