Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

await dispose everywhere #1009

Merged
merged 2 commits into from
May 24, 2021
Merged

await dispose everywhere #1009

merged 2 commits into from
May 24, 2021

Conversation

bruno-garcia
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #1009 (58b85f4) into main (850869a) will increase coverage by 1.72%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
+ Coverage   79.51%   81.24%   +1.72%     
==========================================
  Files         184      184              
  Lines        5903     5907       +4     
  Branches     1454     1456       +2     
==========================================
+ Hits         4694     4799     +105     
+ Misses        801      691     -110     
- Partials      408      417       +9     
Impacted Files Coverage Δ
...ry/Internal/Http/GzipBufferedRequestBodyHandler.cs 91.30% <ø> (ø)
src/Sentry/Envelopes/EnvelopeItem.cs 89.65% <100.00%> (+0.18%) ⬆️
...Sentry/Internal/Extensions/HttpClientExtensions.cs 100.00% <100.00%> (ø)
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <0.00%> (ø)
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 58.62% <0.00%> (+5.17%) ⬆️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 62.50% <0.00%> (+37.50%) ⬆️
...ntry/Integrations/NetFxInstallationsIntegration.cs 100.00% <0.00%> (+66.66%) ⬆️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 72.72% <0.00%> (+68.18%) ⬆️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 71.23% <0.00%> (+71.23%) ⬆️
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 100.00% <0.00%> (+100.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850869a...58b85f4. Read the comment docs.

@bruno-garcia bruno-garcia merged commit 796890b into main May 24, 2021
@bruno-garcia bruno-garcia deleted the ref/await-dispose-everywhere branch May 24, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants