Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further simplify transaction integration from legacy ASP.NET #1011

Merged
merged 3 commits into from
May 24, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented May 24, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #1011 (c32d981) into main (6b60f9c) will decrease coverage by 1.73%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1011      +/-   ##
==========================================
- Coverage   81.49%   79.76%   -1.74%     
==========================================
  Files         184      184              
  Lines        5907     5915       +8     
  Branches     1456     1458       +2     
==========================================
- Hits         4814     4718      -96     
- Misses        676      786     +110     
+ Partials      417      411       -6     
Impacted Files Coverage Δ
src/Sentry.AspNet/HttpContextExtensions.cs 78.26% <50.00%> (-15.08%) ⬇️
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-71.24%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 33.33% <0.00%> (-66.67%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-37.50%) ⬇️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 53.44% <0.00%> (-5.18%) ⬇️
src/Sentry/Internal/BackgroundWorker.cs 84.24% <0.00%> (-0.69%) ⬇️
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b60f9c...c32d981. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! thanks a lot!

@bruno-garcia bruno-garcia enabled auto-merge (squash) May 24, 2021 19:33
@bruno-garcia
Copy link
Member

Sounds like we are ready to add it to the sample and finally the wizard 🥳

@bruno-garcia bruno-garcia merged commit c1bdc78 into main May 24, 2021
@bruno-garcia bruno-garcia deleted the further-improve-aspnet-trans branch May 24, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants