Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add System.Reflection.Metadata as a dependency for netcoreapp3.0 target #1064

Merged
merged 3 commits into from
Jun 18, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Jun 17, 2021

Fixes #1050

@Tyrrrz Tyrrrz added the Bug Something isn't working label Jun 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2021

Codecov Report

Merging #1064 (7a00e77) into main (97ef30f) will decrease coverage by 1.60%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
- Coverage   81.16%   79.55%   -1.61%     
==========================================
  Files         194      194              
  Lines        6349     6349              
  Branches     1530     1530              
==========================================
- Hits         5153     5051     -102     
- Misses        758      868     +110     
+ Partials      438      430       -8     
Impacted Files Coverage Δ
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-71.24%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 33.33% <0.00%> (-66.67%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-37.50%) ⬇️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 53.44% <0.00%> (-5.18%) ⬇️
src/Sentry/GlobalSessionManager.cs 63.15% <0.00%> (-1.76%) ⬇️
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <0.00%> (ø)
src/Sentry/Internal/BackgroundWorker.cs 84.93% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ef30f...7a00e77. Read the comment docs.

@bruno-garcia bruno-garcia enabled auto-merge (squash) June 18, 2021 16:49
@bruno-garcia bruno-garcia merged commit 2ac97c8 into main Jun 18, 2021
@bruno-garcia bruno-garcia deleted the fix-1050 branch June 18, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions not captured since updating to 3.4.0 or above
3 participants