Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IHub.ResumeSession(): don't start a new session if pause wasn't called or if there is no active session #1089

Merged
merged 4 commits into from
Jun 25, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Jun 25, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021

Codecov Report

Merging #1089 (219431b) into main (9a07c9a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
+ Coverage   80.65%   80.70%   +0.04%     
==========================================
  Files         194      194              
  Lines        6354     6359       +5     
  Branches     1409     1411       +2     
==========================================
+ Hits         5125     5132       +7     
  Misses        764      764              
+ Partials      465      463       -2     
Impacted Files Coverage Δ
src/Sentry/GlobalSessionManager.cs 66.66% <100.00%> (+1.91%) ⬆️
src/Sentry/Internal/Hub.cs 69.35% <100.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a07c9a...219431b. Read the comment docs.

@Tyrrrz Tyrrrz merged commit 241ec58 into main Jun 25, 2021
@Tyrrrz Tyrrrz deleted the resume-dont-start-new-if-not-paused branch June 25, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants