Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logger call in BackgroundWorker that caused a formatting exception in runtime #1092

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Fix logger call in BackgroundWorker that caused a formatting exception in runtime #1092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c0efe4
Fix logger call in BackgroundWorker that caused a formatting exceptio…
Tyrrrz Jun 29, 2021
2cede3b
Update changelog
Tyrrrz Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Fixes

- `IHub.ResumeSession()`: don't start a new session if pause wasn't called or if there is no active session ([#1089](https://github.com/getsentry/sentry-dotnet/pull/1089))
- Fix logger call in BackgroundWorker that caused a formatting exception in runtime ([#1092](https://github.com/getsentry/sentry-dotnet/pull/1092))

## 3.6.0

Expand Down
2 changes: 1 addition & 1 deletion src/Sentry/Internal/BackgroundWorker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ private async Task WorkerAsync()
catch (Exception exception)
{
_options.DiagnosticLogger?.LogError(
"Error while processing event {1}: {0}. #{2} in queue.",
"Error while processing envelope (event ID: '{0}'). #{1} in queue.",
exception,
envelope.TryGetEventId(),
_queue.Count
Expand Down