Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persisted Sessions logging #1125

Merged
merged 4 commits into from
Jul 15, 2021
Merged

Persisted Sessions logging #1125

merged 4 commits into from
Jul 15, 2021

Conversation

bitsandfoxes
Copy link
Contributor

Currently persisted sessions not found log as an error for anything else but FileNotFoundException.
I added DirectoryNotFound so both now both log as debug, everything else as error.
Added additional tests for exception type.

@bitsandfoxes bitsandfoxes added the Feature New feature or request label Jul 15, 2021
@bitsandfoxes bitsandfoxes self-assigned this Jul 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2021

Codecov Report

Merging #1125 (8b547be) into main (10b4f6b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
+ Coverage   80.63%   80.65%   +0.02%     
==========================================
  Files         197      197              
  Lines        6589     6592       +3     
  Branches     1453     1455       +2     
==========================================
+ Hits         5313     5317       +4     
  Misses        802      802              
+ Partials      474      473       -1     
Impacted Files Coverage Δ
src/Sentry/GlobalSessionManager.cs 71.20% <100.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b4f6b...8b547be. Read the comment docs.

@bruno-garcia bruno-garcia merged commit e630fbd into main Jul 15, 2021
@bruno-garcia bruno-garcia deleted the fix/persitedsessions branch July 15, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants