Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback to Scope Stack from AspNet. #1180

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Conversation

lucas-zimerman
Copy link
Collaborator

This will stop the null reference exceptions when using the ASP.NET SDK during any Scope interaction that happens before a HttpContext is created.

Close #1157.

@bruno-garcia bruno-garcia marked this pull request as ready for review September 2, 2021 13:02
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #1180 (2b24862) into main (5a305f8) will decrease coverage by 0.00%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1180      +/-   ##
==========================================
- Coverage   80.49%   80.49%   -0.01%     
==========================================
  Files         212      212              
  Lines        6846     6851       +5     
  Branches     1563     1565       +2     
==========================================
+ Hits         5511     5515       +4     
  Misses        823      823              
- Partials      512      513       +1     
Impacted Files Coverage Δ
....AspNet/Internal/HttpContextScopeStackContainer.cs 42.85% <42.85%> (+42.85%) ⬆️
src/Sentry/GlobalSessionManager.cs 69.86% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a305f8...2b24862. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant initialise Sentry if using "AddAspNet" during Init() and HttpContext is null
3 participants