Prevent duplicate package reporting

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Changelog
 
 ## Unreleased
+- Prevent duplicate package reporting ([#1197](https://github.com/getsentry/sentry-dotnet/pull/1197))
 
 ### Fixes
 

src/Sentry/Package.cs

@@ -57,5 +57,30 @@ public static Package FromJson(JsonElement json)
 
             return new Package(name, version);
         }
+
+        /// <inheritdoc />
+        public override int GetHashCode()
+        {
+            unchecked
+            {
+                return (Name.GetHashCode() * 397) ^ Version.GetHashCode();
+            }
+        }
+
+        /// <inheritdoc />
+        public override bool Equals(object? obj)
+        {
+            if (ReferenceEquals(this, obj))
+            {
+                return true;
+            }
+
+            if (obj is Package package)
+            {
+                return Name == package.Name && Version == package.Version;
+            }
+
+            return false;
+        }
     }
 }

src/Sentry/SdkVersion.cs

@@ -66,7 +66,7 @@ public void WriteTo(Utf8JsonWriter writer)
         {
             writer.WriteStartObject();
 
-            writer.WriteArrayIfNotEmpty("packages", InternalPackages);
+            writer.WriteArrayIfNotEmpty("packages", InternalPackages.Distinct());
             writer.WriteStringIfNotWhiteSpace("name", Name);
             writer.WriteStringIfNotWhiteSpace("version", Version);
 

test/Sentry.Tests/Protocol/SdkVersionTests.cs

@@ -1,5 +1,6 @@
 using System.Collections.Generic;
 using System.Linq;
+using System.Text.RegularExpressions;
 using Sentry.Tests.Helpers;
 using Xunit;
 
@@ -57,5 +58,41 @@ public static IEnumerable<object[]> TestCases()
             sdk.AddPackage("a", "1");
             yield return new object[] { (sdk, "{\"packages\":[{\"name\":\"a\",\"version\":\"1\"},{\"name\":\"b\",\"version\":\"2\"}]}") };
         }
+
+        [Fact]
+        public void SerializeObject_IgnoresDuplicatePackages()
+        {
+            var sdkVersion = new SdkVersion
+            {
+                Name = "Sentry.Test.SDK",
+                Version = "3.9.2"
+            };
+            sdkVersion.AddPackage("Foo", "Alpha");
+            sdkVersion.AddPackage("Bar", "Beta");
+            var actual = sdkVersion.ToJsonString();
+            var expected = TrimJson(@"
+{
+   ""packages"": [
+        {
+            ""name"": ""Bar"",
+            ""version"": ""Beta""
+        },
+        {
+            ""name"": ""Foo"",
+            ""version"": ""Alpha""
+        }
+    ],
+    ""name"": ""Sentry.Test.SDK"",
+    ""version"": ""3.9.2""
+}");
+            Assert.Equal(expected, actual);
+
+        }
+
+        private static string TrimJson(string json)
+        {
+            return Regex.Replace(json, @"\s", "");
+        }
+
     }
 }