Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish unfinished Spans on Transaction completion #1296

Merged
merged 22 commits into from
Nov 8, 2021
Merged

Finish unfinished Spans on Transaction completion #1296

merged 22 commits into from
Nov 8, 2021

Commits on Nov 2, 2021

  1. add test case.

    @lucas-zimerman
    lucas-zimerman committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    c2d186b View commit details
    Browse the repository at this point in the history

  2. Update test.

    @lucas-zimerman
    lucas-zimerman committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    872c2c1 View commit details
    Browse the repository at this point in the history

  3. removed some moqs

    @lucas-zimerman
    lucas-zimerman committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    e2a32d1 View commit details
    Browse the repository at this point in the history

  4. Code cleanup

    @lucas-zimerman
    lucas-zimerman committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    5591695 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Close spans with events without exceptions.

    @lucas-zimerman
    lucas-zimerman committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    34c498a View commit details
    Browse the repository at this point in the history

  2. Format code

    @getsentry-bot
    getsentry-bot committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    ae96241 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. rollback Hub CaptureEvent, removed A and implemented close unfinish… 

    …ed Spans.
    @lucas-zimerman
    lucas-zimerman committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    cfb2519 View commit details
    Browse the repository at this point in the history

  2. typo.

    @lucas-zimerman
    lucas-zimerman committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    9d3ddeb View commit details
    Browse the repository at this point in the history

  3. Tests fixes.

    @lucas-zimerman
    lucas-zimerman committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    d04bf92 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix/message-only-errors-not-closing-span

    @lucas-zimerman
    lucas-zimerman authored Nov 4, 2021
    Configuration menu
    Copy the full SHA
    8038daa View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. small refactor

    @lucas-zimerman
    lucas-zimerman committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    657c9b5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix/message-only-errors-not-closing-span' of https://gi… 

    …thub.com/getsentry/sentry-dotnet into fix/message-only-errors-not-closing-span
    @lucas-zimerman
    lucas-zimerman committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    3c943fd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/message-only-errors-not-closing-span

    @lucas-zimerman
    lucas-zimerman authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    0bd5097 View commit details
    Browse the repository at this point in the history

  4. Update changelog.

    @lucas-zimerman
    lucas-zimerman committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    272eece View commit details
    Browse the repository at this point in the history

  5. Self code review fixes.

    @lucas-zimerman
    lucas-zimerman committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    07374b2 View commit details
    Browse the repository at this point in the history

  6. Moved OR condition to the left side.

    @lucas-zimerman
    lucas-zimerman committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    f30239b View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Removed unneeded Span close.

    @lucas-zimerman
    lucas-zimerman committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    a92e53c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/message-only-errors-not-closing-span

    @lucas-zimerman
    lucas-zimerman authored Nov 8, 2021
    Configuration menu
    Copy the full SHA
    1223d3d View commit details
    Browse the repository at this point in the history

  3. Format code

    @getsentry-bot
    getsentry-bot committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    dc2895a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix/message-only-errors-not-closing-span

    @lucas-zimerman
    lucas-zimerman authored Nov 8, 2021
    Configuration menu
    Copy the full SHA
    bb0063e View commit details
    Browse the repository at this point in the history

  5. Removed unused extension.

    @lucas-zimerman
    lucas-zimerman committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    fa2aa9e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'fix/message-only-errors-not-closing-span' of https://gi… 

    …thub.com/getsentry/sentry-dotnet into fix/message-only-errors-not-closing-span
    @lucas-zimerman
    lucas-zimerman committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    b25266a View commit details
    Browse the repository at this point in the history