Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't leave leftovers for SQLClient #1317

Merged
merged 8 commits into from
Nov 9, 2021

Conversation

lucas-zimerman
Copy link
Collaborator

All connection spans are closed with the correct Connection Id. Previously only one of the connection Spans with the same connection Id was going to be set. Now, this results in spans with deadlines instead of being ignored due to this PR #1296.

Might be hard to visualize, but this
image
Will now become
image

The appearance will depend on the connectivity code used by the client, for some operations the appearance will remain the same, as shown below:
image

@lucas-zimerman lucas-zimerman marked this pull request as ready for review November 8, 2021 23:15
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021

Codecov Report

Merging #1317 (78f2ec0) into main (72f751f) will increase coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head 78f2ec0 differs from pull request most recent head cddbf5c. Consider uploading reports for the commit cddbf5c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1317   +/-   ##
=======================================
  Coverage   82.61%   82.61%           
=======================================
  Files         215      215           
  Lines        7150     7146    -4     
  Branches     1407     1406    -1     
=======================================
- Hits         5907     5904    -3     
  Misses        808      808           
+ Partials      435      434    -1     
Impacted Files Coverage Δ
...ce/Internals/DiagnosticSource/SentrySqlListener.cs 81.69% <33.33%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e8d0b...cddbf5c. Read the comment docs.

@SimonCropp SimonCropp merged commit 6d541aa into main Nov 9, 2021
@SimonCropp SimonCropp deleted the fix/ajust-diagnostic-source branch November 9, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants