Dont autoverify on BuildServer #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we only want to auto accept changes locally. eg non verified changes should still fail on the build server
SimonCropp
requested review from
bruno-garcia and
lucas-zimerman
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1341 +/- ##
=======================================
Coverage 82.64% 82.64%
=======================================
Files 215 215
Lines 7145 7145
Branches 1407 1407
=======================================
Hits 5905 5905
Misses 806 806
Partials 434 434 Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
Nov 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we only want to auto accept changes locally. ie non verified changes should still fail on the build server
#skip-changelog
should prevent breaking changes like #1296