Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentry to global usings #1398

Merged
merged 15 commits into from
Jan 14, 2022
Merged

Add Sentry to global usings #1398

merged 15 commits into from
Jan 14, 2022

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Dec 16, 2021

fixes #1163

@lucas-zimerman
Copy link
Collaborator

Is it possible to add some tests for it?

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Do we need a major bump here and docs to help users opt-out if they have conflicts?

More importantly: Isn't this going to immediately break anyone using Span<T>?

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #1398 (76e2c80) into main (4f304c1) will decrease coverage by 1.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
- Coverage   84.16%   82.79%   -1.38%     
==========================================
  Files         219      219              
  Lines        7346     7346              
  Branches     1409     1409              
==========================================
- Hits         6183     6082     -101     
- Misses        729      838     +109     
+ Partials      434      426       -8     
Impacted Files Coverage Δ
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-70.43%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-37.50%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 28.57% <0.00%> (-28.58%) ⬇️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 53.44% <0.00%> (-5.18%) ⬇️
src/Sentry/Internal/BackgroundWorker.cs 92.02% <0.00%> (-1.45%) ⬇️
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f304c1...76e2c80. Read the comment docs.

@bruno-garcia
Copy link
Member

@SimonCropp feel free to merge this once we have some docs to go with it.
I also propose causing a conflict on purpose to get an error message and throw it in the Troubleshooting page: https://docs.sentry.io/platforms/dotnet/troubleshooting/ There we can point out how users can't opt-out of this or how to resolve the conflict. If that would be beneficial.

@SimonCropp SimonCropp enabled auto-merge (squash) January 13, 2022 23:48
@SimonCropp SimonCropp enabled auto-merge (squash) January 13, 2022 23:49
@SimonCropp SimonCropp enabled auto-merge (squash) January 13, 2022 23:51
@SimonCropp SimonCropp merged commit 6f90524 into main Jan 14, 2022
@SimonCropp SimonCropp deleted the Add-Sentry-to-global-usings branch January 14, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sentry to global usings
4 participants