Add TransactionNameProvider to allow the name definition from Unknown transactions on ASP.NET Core #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-zimerman
added
Feature
bruno-garcia
reviewed
Jan 4, 2022
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Codecov Report
@@ Coverage Diff @@
## main #1421 +/- ##
==========================================
- Coverage 83.41% 82.79% -0.63%
==========================================
Files 219 219
Lines 7370 7374 +4
Branches 1411 1412 +1
==========================================
- Hits 6148 6105 -43
- Misses 790 840 +50
+ Partials 432 429 -3
Continue to review full report at Codecov.
|
lucas-zimerman
changed the title
SimonCropp
approved these changes
Jan 20, 2022
Use delegate for transaction name
lucas-zimerman
changed the title
lucas-zimerman
commented
Jan 21, 2022
|
do we need a corresponding docs PR? |
We deffo need some docs but I believe we could work on it once we have a released version with this PR bundled. |
bruno-garcia
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to allow the user to set the transaction name on cases where the SDK isn't able to define the current Transaction name.
I'm also altering the GCP Integration since it already uses the integration, but without relying on the HttpContext to set the name.
Solves #1373.