Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced the logger noise from EF when not using Performance Monitoring #1441

Merged
merged 8 commits into from
Feb 1, 2022

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Jan 18, 2022

  • Database performance integration if SampleRate is zero
  • lowered the logger level if the transaction was not found.

Fixes #1440

…e logger level if transaction was not found.
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #1441 (2f6b566) into main (2324af6) will increase coverage by 0.02%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
+ Coverage   84.16%   84.18%   +0.02%     
==========================================
  Files         219      219              
  Lines        7374     7379       +5     
  Branches     1412     1416       +4     
==========================================
+ Hits         6206     6212       +6     
+ Misses        732      729       -3     
- Partials      436      438       +2     
Impacted Files Coverage Δ
....EntityFramework/SentryQueryPerformanceListener.cs 86.36% <0.00%> (+10.17%) ⬆️
...entry.EntityFramework/DbInterceptionIntegration.cs 88.88% <87.50%> (-11.12%) ⬇️
src/Sentry/Exceptions/Mechanism.cs 82.35% <0.00%> (-2.95%) ⬇️
...Sentry/Extensibility/DiagnosticLoggerExtensions.cs 43.58% <0.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2324af6...2f6b566. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
src/Sentry.EntityFramework/SentryOptionsExtensions.cs Outdated Show resolved Hide resolved
@bruno-garcia bruno-garcia marked this pull request as ready for review January 18, 2022 20:25
@lucas-zimerman lucas-zimerman changed the title Reduced the logger noise from EF when using Performance Monitoring Reduced the logger noise from EF when not using Performance Monitoring Jan 19, 2022
@lucas-zimerman lucas-zimerman merged commit ad6f005 into main Feb 1, 2022
@lucas-zimerman lucas-zimerman deleted the fix/ef-transactions-with-sample-zero branch February 1, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry.EntityFramework spamming diagnostic logs
4 participants