-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore zero properties for MemoryInfo #1531
Conversation
… props are stubbed out to zero
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's some API we can call that will tell us whether GetGCMemoryInfo
returns meaningful data or not. I mean: When do we get all zeros/defaults?
Codecov Report
@@ Coverage Diff @@
## main #1531 +/- ##
==========================================
- Coverage 84.43% 82.73% -1.70%
==========================================
Files 219 219
Lines 7388 7398 +10
Branches 1416 1421 +5
==========================================
- Hits 6238 6121 -117
- Misses 722 852 +130
+ Partials 428 425 -3
Continue to review full report at Codecov.
|
not from my research |
WriteNumberIfNotZero since on OS that dont implement all props, thos props are stubbed out to zero