Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and update Android options #1705

Merged
merged 2 commits into from
Jun 11, 2022
Merged

Refactor and update Android options #1705

merged 2 commits into from
Jun 11, 2022

Conversation

mattjohnsonpint
Copy link
Contributor

This continues adding support for setting options for the Android SDK from within the .NET SDK (for the net6.0-android target).

  • Refactored/reorganized code under /src/Sentry/Android
  • Improved handling of Java enums
  • Mapped objects in BeforeBreadcrumb callback to avoid serialization
  • Added a length comment to the serialization in the BeforeSend callback and left it there
  • Added two new options that are disabled by default. The user can opt-in if desired:
    • EnableAndroidSdkBeforeSend - Controls if the BeforeSend option is passed to the Android SDK
    • EnableAndroidSdkTracing - Controls if the TracesSampleRate and TracesSampler options are passed to the Android SDK
  • Several other minor improvements

@mattjohnsonpint mattjohnsonpint merged commit 89cad6d into main Jun 11, 2022
@mattjohnsonpint mattjohnsonpint deleted the android-options-2 branch June 11, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants