Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAUI events become extra context in Sentry events #1706

Merged
merged 5 commits into from
Jun 13, 2022
Merged

Conversation

mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Jun 11, 2022

Continues #1651

  • Hook into MAUI events (adds breadcrumbs for now, will add spans for tracing support later)
    • We still will need to do more work here to reduce the number of breadcrumbs sent to those that are meaningful only, include additional data for some events where useful, and remove some data items that might contain PII.

Also:

  • Hooks the Microsoft.UI.Xaml.Application.UnhandledException handler when targeting Windows
  • Fixes the previous workaround in the sample app's csproj, so it runs on iOS and maccatalyst without crashing
  • Adds a workaround that lets unhandled exceptions (crashes) be caught properly for iOS and maccatalyst.
  • Registers a Disposer that will ensure the Sentry SDK is disposed with the ServiceProvider, so we flush events to Sentry during shutdown.

CHANGELOG.md Outdated Show resolved Hide resolved
src/Sentry.Maui/Internal/Extensions.cs Show resolved Hide resolved
@mattjohnsonpint mattjohnsonpint changed the title Continue with adding MAUI support MAUI events become extra context in Sentry events Jun 13, 2022
@mattjohnsonpint mattjohnsonpint merged commit bbf2f4a into main Jun 13, 2022
@mattjohnsonpint mattjohnsonpint deleted the maui-3 branch June 13, 2022 20:51
@mattjohnsonpint mattjohnsonpint restored the maui-3 branch June 13, 2022 20:54
@getsentry getsentry deleted a comment from github-actions bot Jun 13, 2022
@mattjohnsonpint mattjohnsonpint deleted the maui-3 branch June 13, 2022 20:55
@mattjohnsonpint mattjohnsonpint mentioned this pull request Jun 14, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants