Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Warning when secret is detected in DSN #1749

Merged
merged 8 commits into from
Jun 28, 2022
Merged

Log Warning when secret is detected in DSN #1749

merged 8 commits into from
Jun 28, 2022

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Jun 25, 2022 •
edited by mattjohnsonpint
Loading

quoting @bruno-garcia

Secret has been deprecated so many years ago that we can just delete it at this point. The SDK requires the /envelope endpoint so doesn't support old Sentry's that would require a secret in the DSN

#1747 (comment)

#skip-changelog

@getsentry getsentry deleted a comment from github-actions bot Jun 25, 2022
@mattjohnsonpint
Copy link
Contributor

Perhaps we should add some logic that logs a warning message if they pass a DSN that includes a secret?

bruno-garcia
bruno-garcia approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler. Thanks!

@bruno-garcia
Copy link
Member

Perhaps we should add some logic that logs a warning message if they pass a DSN that includes a secret?

There's no problem with having the secret, it's just not going to be used for anything on the server.

@SimonCropp SimonCropp changed the title consolidate dns strings in tests Log Warning when secret is detected in DSN Jun 28, 2022
@getsentry getsentry deleted a comment from github-actions bot Jun 28, 2022
@SimonCropp
Copy link
Contributor Author

i added a warning when secret is detected

@mattjohnsonpint mattjohnsonpint merged commit c5d84bf into main Jun 28, 2022
@mattjohnsonpint mattjohnsonpint deleted the consolodate-dns-strings-in-tests branch June 28, 2022 21:28
@getsentry getsentry deleted a comment from github-actions bot Jun 28, 2022
@mattjohnsonpint
Copy link
Contributor

Fixed merge with #1758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjohnsonpint mattjohnsonpint mattjohnsonpint left review comments

@bruno-garcia bruno-garcia bruno-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonCropp @mattjohnsonpint @bruno-garcia