Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't dispose hub in unhandled exception handler #1794

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Don't dispose hub in unhandled exception handler #1794

merged 1 commit into from
Jul 21, 2022

Conversation

mattjohnsonpint
Copy link
Contributor

Fixes #1772

@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review July 21, 2022 01:15
@mattjohnsonpint
Copy link
Contributor Author

@bitsandfoxes - can you try your repro of the issue with this change? Thanks.

@mattjohnsonpint mattjohnsonpint merged commit 6b9f329 into main Jul 21, 2022
@mattjohnsonpint mattjohnsonpint deleted the fix-unity-background-exception-issue branch July 21, 2022 04:11
@vaind
Copy link
Collaborator

vaind commented Jul 21, 2022

can you try your repro of the issue with this change? Thanks.

yes it fixes the issue in Unity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonCropp SimonCropp SimonCropp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exceptions on background thread are not handled and reported correctly
3 participants
@mattjohnsonpint @vaind @SimonCropp