Fix Sentry interfering with MAUI's focus events #1891
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1886
We were binding to
Microsoft.Maui.Controls.VisualElement.FocusChangeRequested
via reflection. That particular event has a handler that requires settinge.Result = true
in order to not block the focus request. Unfortunately, the default is false (ouch!).FocusChangeRequested
is marked with[EditorBrowsable(EditorBrowsableState.Never)]
, indicating it's not meant for public consumption. We probably shouldn't have been attaching to it at all.Fixed this in two ways:
EditorBrowsable
(unless its param isAlways
)VisualElement
so we can better control the specific events from that type.