Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added instruction_addr_adjustment attribute #2151

Merged
merged 8 commits into from
Feb 8, 2023

Conversation

bitsandfoxes
Copy link
Contributor

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 09837d6

@mattjohnsonpint
Copy link
Contributor

From reading the RFC and looking at the Relay implementation, I think this is supposed to go on SentryStackTrace, not on SentryStackFrame.

@mattjohnsonpint
Copy link
Contributor

The per-frame field is the adjust_instruction_addr boolean mentioned later in the RFC that Symbolicator adds.

@bitsandfoxes bitsandfoxes marked this pull request as ready for review February 8, 2023 17:39
mattjohnsonpint

This comment was marked as outdated.

@mattjohnsonpint mattjohnsonpint merged commit 9f7caf1 into main Feb 8, 2023
@mattjohnsonpint mattjohnsonpint deleted the feat/instr-addr-adj branch February 8, 2023 18:10
@mattjohnsonpint
Copy link
Contributor

Thanks @bitsandfoxes ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants