Fix Sentry CLI MSBuild for Xamarin and NetFX #2154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some further testing on Xamarin and .NET Framework projects after the 3.27.0 release, found symbol uploads not working as expected.
We can't rely on checking for a non-empty
TargetFramework
property, because that only exists in the newer SDK-style .NET projects. Since the intention here is to run for anything other than the outer build when multi-targeting, we can check for an emptyInnerTargets
property (which is only set in the case we need to exclude).On Xamarin Android projects, we always will need the
obj
folder contents rather thanbin
to get the correct debug files uploaded. Since theobj
folder is guaranteed to always have the files we need, we should make it the default and remove theSentryIncludeIntermediateOutputPath
option. (We don't need to use thebin
folder at all.)