Allow SentryUploadSources to work even when not uploading symbols #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mattjohnsonpint
requested review from
vaind
and removed request for
bitsandfoxes
Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2196
Caveat: Symbols still need to be created, even if they're not uploaded. If symbols are not created, we can't resolve the files needed to generate the source bundle.
Additionally, if symbols are embedded (using
<DebugType>embedded</DebugType), sources won't be uploaded due to getsentry/sentry-cli#1491. Once that is fixed, the subsequent version of Sentry CLI will remove this limitation.