Attach stack trace when events have captured an exception without a stack trace #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bruno-garcia
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
AttachStackTraceistrue(the default behavior), we now ensure that a stack trace exists on all events.Previously, we'd only have a stack trace on events with a _thrown_exception, or events that had no exception. This expands the feature to include a stack trace when an exception is captured without being thrown.
An stack trace like this will be sent to Sentry separately from the exception, but the Sentry issue details UI will still show them together. If source context is available, the highlighted call site is likely to be the location where the exception was captured. For example:
Resolves #2262