Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Baggage header parsing in ASP.NET (Framework) #2293

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

kuhnroyal
Copy link
Contributor

This uses the wrong header name when parsing the baggage.

@mattjohnsonpint
Copy link
Contributor

For everyone's awareness, this bug fix applies to ASP.NET (framework), not ASP.NET Core.

The baggage header is used by Sentry for supplying dynamic sampling context during distributing tracing. So if you are using ASP.NET (framework) to server APIs, and those APIs are being called by other applications that are instrumented with Sentry, then those applications would pass the baggage header containing dynamic sampling context. This bug fix is important for that scenario.

If you're just rendering HTML content directly (such as with MVC views, etc.), then this doesn't apply.

@kuhnroyal - Thanks for finding and fixing this!

@mattjohnsonpint mattjohnsonpint changed the title Update Baggage header name in HttpContextExtensions.cs Fix Baggage header parsing in ASP.NET (Framework) Apr 6, 2023
@mattjohnsonpint mattjohnsonpint merged commit 9c6ad39 into getsentry:main Apr 6, 2023
@kuhnroyal kuhnroyal deleted the kuhnroyal-patch-1 branch April 6, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants