Buffer payloads asynchronously when appropriate #2297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During serialization, we buffer payloads of
EnvelopeItems
into memory so we can calculate lengths to include in headers.As part of #1965 (released in 3.22.0), I switched to synchronous buffering of these payloads - because serialization of a fully materialized object to a
MemoryStream
gains no advantage by being async, and doing so adds some minor overhead.That is still true, however I didn't consider that not all payloads are fully materialized. In particular, a
StreamSerializable
could be representing an attachment, in which case it would be reading from aFileStream
or any other type ofStream
(depending on how it was attached). Also, we may need other types of async materialization in the future.Thus, we should defer to synchronous buffering only when we know the object is fully materialized - which is what our
JsonSerializable
class represents.