Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve WithScope and add WithScopeAsync #2303

Merged
merged 10 commits into from
Apr 17, 2023
Merged

Improve WithScope and add WithScopeAsync #2303

merged 10 commits into from
Apr 17, 2023

Conversation

mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Apr 16, 2023 •
edited
Loading

  • Un-obsoletes WithScope
  • Adds WithScope<T>, WithScopeAsync, and WithScopeAsync<T>

Resolves #2300

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2023 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against be38b7f

SeanFeldman
SeanFeldman reviewed Apr 17, 2023
View reviewed changes
Copy link
Contributor

@SeanFeldman SeanFeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions

src/Sentry/SentrySdk.cs Outdated Show resolved Hide resolved
src/Sentry/SentrySdk.cs Outdated Show resolved Hide resolved
src/Sentry/SentrySdk.cs Outdated Show resolved Hide resolved
src/Sentry/Internal/SentryScopeManager.cs Show resolved Hide resolved
@mattjohnsonpint mattjohnsonpint merged commit efb5dc8 into main Apr 17, 2023
@mattjohnsonpint mattjohnsonpint deleted the feat/withscope branch April 17, 2023 20:13
This was referenced Apr 18, 2023
Merged
Open
This was referenced May 11, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanFeldman SeanFeldman SeanFeldman approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes bitsandfoxes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable WithScope and WithScopeAsync
2 participants
@mattjohnsonpint @SeanFeldman