Remove ios simulator resources when building in Hot Restart mode #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanFeldman
approved these changes
May 22, 2023
jamescrosswell
approved these changes
May 22, 2023
|
For posterity, here's the portion of the build log (using the ms binlog viewer) showing what is removed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native resources from our Sentry Cocoa SDK (
Sentry.xcframeworks) do not need to include files that are for the iOS simulator, when we're building for "Hot Restart" mode in Visual Studio - since that is specifically for going direct to device.The simulator files add a few extra layers of directories, which can easily exceed Windows max path. Removing them avoids this, without affecting functionality.
Tested locally on Visual Studio 17.6.0 on Windows.
Fixes #2363