Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/DB Connection spans presented poorly #2409

Merged
merged 33 commits into from
Jun 9, 2023
Merged

Fix/DB Connection spans presented poorly #2409

merged 33 commits into from
Jun 9, 2023

Commits on May 29, 2023

  1. Refactored Add/Finish spans logic into Helper classes

    @jamescrosswell
    jamescrosswell committed May 29, 2023
    Configuration menu
    Copy the full SHA
    a1fb23f View commit details
    Browse the repository at this point in the history

  2. Implemented logic to correlate Add/Finish spans using Diagnostic Conn… 

    …ectionId and CommandId
    @jamescrosswell
    jamescrosswell committed May 29, 2023
    Configuration menu
    Copy the full SHA
    80d24bb View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Replaced AsyncLocl<WeakReference> with Correlation IDs extracted from… 

    … EF diagnostic events
    @jamescrosswell
    jamescrosswell committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    54fe8a2 View commit details
    Browse the repository at this point in the history

  2. Refactored to use Extra instead of TraceData, for consistency with Se… 

    …ntrySqlListener
    @jamescrosswell
    jamescrosswell committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    086a8be View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/db-spans-not-finishing

    @jamescrosswell
    jamescrosswell committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    589fab1 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md

    @jamescrosswell
    jamescrosswell authored Jun 1, 2023
    Configuration menu
    Copy the full SHA
    fe73cbf View commit details
    Browse the repository at this point in the history

  5. Update SqlListenerTests.RecordsEf.Net4_8.verified.txt

    @jamescrosswell
    jamescrosswell committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    f1e9785 View commit details
    Browse the repository at this point in the history

  6. Undo csproj whitespace

    @mattjohnsonpint
    mattjohnsonpint committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    2ac37af View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Matt Johnson-Pint <matt.johnson-pint@sentry.io>
    @jamescrosswell @mattjohnsonpint
    jamescrosswell and mattjohnsonpint authored Jun 1, 2023
    Configuration menu
    Copy the full SHA
    6b731f0 View commit details
    Browse the repository at this point in the history

  8. Refactored SentryEFCoreListener so DiagnosticSourceHelpers are create… 

    …d only once
    @jamescrosswell
    jamescrosswell committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    852e160 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Merge branch 'fix/db-spans-not-finishing' of https://github.com/getse… 

    …ntry/sentry-dotnet into fix/db-spans-not-finishing
    @jamescrosswell
    jamescrosswell committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    64732f5 View commit details
    Browse the repository at this point in the history

  2. Implemented fix for DB Connection spans presented poorly #2144

    @jamescrosswell
    jamescrosswell committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    5dc7010 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/db-spans-presentation

    @jamescrosswell
    jamescrosswell committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    f869c51 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md

    @jamescrosswell
    jamescrosswell committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    945393c View commit details
    Browse the repository at this point in the history

  5. Fixed timing in OnNext_Same_Connections_Consolidated so we can reliab… 

    …ly compare TimeStamps
    @jamescrosswell
    jamescrosswell committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    fa21697 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Moved db.query spans back under the associated db.connection

    @jamescrosswell
    jamescrosswell committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    ec44c6b View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. EFConnectionDiagnosticSourceHelper now uses the "Connection.Database"… 

    … as a description
    @jamescrosswell
    jamescrosswell committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    fa0f431 View commit details
    Browse the repository at this point in the history

  2. Fixed errors with unit tests

    @jamescrosswell
    jamescrosswell committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    a9010d9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of git@github.com:getsentry/sentry-dotnet.git int… 

    …o fix/db-spans-presentation
    @jamescrosswell
    jamescrosswell committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    37cc1bf View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Merge branch 'main' into fix/db-spans-presentation

    @mattjohnsonpint
    mattjohnsonpint committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    f278a58 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md

    @mattjohnsonpint
    mattjohnsonpint committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    f54f332 View commit details
    Browse the repository at this point in the history

  3. fix merge conflict

    @mattjohnsonpint
    mattjohnsonpint committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    8448f47 View commit details
    Browse the repository at this point in the history

  4. nits

    @mattjohnsonpint
    mattjohnsonpint committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    232ceaf View commit details
    Browse the repository at this point in the history

  5. Update extension method improvements to apply to all property types

    @mattjohnsonpint
    mattjohnsonpint committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    93dff1b View commit details
    Browse the repository at this point in the history

  6. Restore test changes (bad merge)

    @mattjohnsonpint
    mattjohnsonpint committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    551a20b View commit details
    Browse the repository at this point in the history

  7. Fixed whitespace error in Verify tests

    @jamescrosswell
    jamescrosswell committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    9eec767 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Flattened DB Connection and Query spans produced by the Sentry DB Dia… 

    …gnostic listeners
    @jamescrosswell
    jamescrosswell committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    028c7b6 View commit details
    Browse the repository at this point in the history

  2. Renamed verify tests to conform with async naming conventions

    @jamescrosswell
    jamescrosswell committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    f7decd0 View commit details
    Browse the repository at this point in the history

  3. SqlClient diagnostics now uses the Databasename to describe db.connec… 

    …tion spans
    @jamescrosswell
    jamescrosswell committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    553e69a View commit details
    Browse the repository at this point in the history

  4. nits

    @mattjohnsonpint
    mattjohnsonpint committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    8525585 View commit details
    Browse the repository at this point in the history

  5. Fixed typos

    @jamescrosswell
    jamescrosswell committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    1b100f2 View commit details
    Browse the repository at this point in the history

  6. EFCommand operations now record the db.name in the Span.Extra properties

    @jamescrosswell
    jamescrosswell committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    5186953 View commit details
    Browse the repository at this point in the history

  7. Update SqlListenerTests.RecordsEfAsync.Net4_8.verified.txt

    @mattjohnsonpint
    mattjohnsonpint committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    7bd629b View commit details
    Browse the repository at this point in the history