-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test on net8 #2617
test on net8 #2617
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- test on net8 ([#2617](https://github.com/getsentry/sentry-dotnet/pull/2617)) If none of the above apply, you can opt out of this check by adding |
@@ -1,6 +1,6 @@ | |||
<Project Sdk="Microsoft.NET.Sdk"> | |||
<PropertyGroup> | |||
<TargetFramework>net6.0-android</TargetFramework> | |||
<TargetFrameworks>net7.0-android</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be a breaking change but had to do this to get things to compile. We can try getting back to 6 before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to this:
Error: /Users/runner/.dotnet/sdk/8.0.100-rc.1.23455.8/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: wasm-tools-net6 [/Users/runner/work/sentry-dotnet/sentry-dotnet/src/Sentry.Maui/Sentry.Maui.csproj::TargetFramework=net6.0-ios]
Superseded by: #2622 |
.NET 8 RC1 is out (that's Go Live license).
RC is a good time for us to make sure things work fine