Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Scope not being applied to OpenTelemetry spans in ASP.NET Core #2690

Merged
merged 15 commits into from
Oct 9, 2023
Merged

Fix: Scope not being applied to OpenTelemetry spans in ASP.NET Core #2690

merged 15 commits into from
Oct 9, 2023

Commits on Oct 3, 2023

  1. Added keyed scopes to SentryScopeManager

    @jamescrosswell
    jamescrosswell committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    17e620f View commit details
    Browse the repository at this point in the history

  2. Capture and propagate the HttpRequest through the SpanProcessor

    @jamescrosswell
    jamescrosswell committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    2685499 View commit details
    Browse the repository at this point in the history

  3. Replaced the HttpRequestScopeKeyResolver with an ActivityRootIdKeyRes… 

    …olver
    @jamescrosswell
    jamescrosswell committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    cb6f2c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Scopes are now saved by our middleware so these can be restored/appli… 

    …ed during OpenTelemetry span processing
    @jamescrosswell
    jamescrosswell committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    7d05542 View commit details
    Browse the repository at this point in the history

  2. Delete HttpContextScopeStackContainer.cs

    @jamescrosswell
    jamescrosswell committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    cd2d033 View commit details
    Browse the repository at this point in the history

  3. Removed unnecessary code from previous experiments

    @jamescrosswell
    jamescrosswell committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    549a0d9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix/no-scopes-for-otel

    @jamescrosswell
    jamescrosswell authored Oct 4, 2023
    Configuration menu
    Copy the full SHA
    a2479f2 View commit details
    Browse the repository at this point in the history

  5. Update SentrySpanProcessor.cs

    @jamescrosswell
    jamescrosswell committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    2e4e4b5 View commit details
    Browse the repository at this point in the history

  6. Update CHANGELOG.md

    @jamescrosswell
    jamescrosswell committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    97f651e View commit details
    Browse the repository at this point in the history

  7. Added Core3_1.verified file

    @jamescrosswell
    jamescrosswell committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    7ce05e0 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Review feedback

    @jamescrosswell
    jamescrosswell committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4066bb8 View commit details
    Browse the repository at this point in the history

  2. Update ApiApprovalTests.Run.Core3_1.verified.txt

    @jamescrosswell
    jamescrosswell committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4572493 View commit details
    Browse the repository at this point in the history

  3. Added unit tests

    @jamescrosswell
    jamescrosswell committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    9fb54a5 View commit details
    Browse the repository at this point in the history

  4. Save Scope rather than Scope.Clone

    @jamescrosswell
    jamescrosswell committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    d189a78 View commit details
    Browse the repository at this point in the history

  5. Update src/Sentry.OpenTelemetry/SentrySpanProcessor.cs 

    comment
    @bitsandfoxes
    bitsandfoxes authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    aa2f820 View commit details
    Browse the repository at this point in the history