Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unobsoleted SentryClient.Dispose #2842

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Unobsoleted SentryClient.Dispose #2842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d107f27
dispose no longer a problem
bitsandfoxes Nov 15, 2023
37e0328
Merge branch 'feat/4.0.0' into feat/client-dispose-obsolete
bitsandfoxes Nov 16, 2023
be6d9e8
verified
bitsandfoxes Nov 16, 2023
d6ecb2f
Updated CHANGELOG.md
bitsandfoxes Nov 16, 2023
7d1d1d0
Merge branch 'feat/4.0.0' into feat/client-dispose-obsolete
vaind Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#### Changed APIs

- `DebugImage` and `DebugMeta` moved to `Sentry.Protocol` namespace. ([#2815](https://github.com/getsentry/sentry-dotnet/pull/2815))
- `SentryClient.Dispose` is no longer obsolete ([#2842](https://github.com/getsentry/sentry-dotnet/pull/2842))

## 4.0.0-alpha.0

Expand Down
1 change: 0 additions & 1 deletion src/Sentry/SentryClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,6 @@ private bool CaptureEnvelope(Envelope envelope)
/// Disposes this client
/// </summary>
/// <inheritdoc />
[Obsolete("Sentry client should not be explicitly disposed of. This method will be removed in version 4.")]
public void Dispose()
{
_options.LogDebug("Flushing SentryClient.");
Expand Down
2 changes: 0 additions & 2 deletions test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,8 +482,6 @@ namespace Sentry
public void CaptureTransaction(Sentry.Transaction transaction) { }
public void CaptureTransaction(Sentry.Transaction transaction, Sentry.Hint? hint) { }
public void CaptureUserFeedback(Sentry.UserFeedback userFeedback) { }
[System.Obsolete("Sentry client should not be explicitly disposed of. This method will be removed i" +
"n version 4.")]
public void Dispose() { }
public System.Threading.Tasks.Task FlushAsync(System.TimeSpan timeout) { }
}
Expand Down
2 changes: 0 additions & 2 deletions test/Sentry.Tests/ApiApprovalTests.Run.DotNet7_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,8 +482,6 @@ namespace Sentry
public void CaptureTransaction(Sentry.Transaction transaction) { }
public void CaptureTransaction(Sentry.Transaction transaction, Sentry.Hint? hint) { }
public void CaptureUserFeedback(Sentry.UserFeedback userFeedback) { }
[System.Obsolete("Sentry client should not be explicitly disposed of. This method will be removed i" +
"n version 4.")]
public void Dispose() { }
public System.Threading.Tasks.Task FlushAsync(System.TimeSpan timeout) { }
}
Expand Down
2 changes: 0 additions & 2 deletions test/Sentry.Tests/ApiApprovalTests.Run.DotNet8_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,8 +482,6 @@ namespace Sentry
public void CaptureTransaction(Sentry.Transaction transaction) { }
public void CaptureTransaction(Sentry.Transaction transaction, Sentry.Hint? hint) { }
public void CaptureUserFeedback(Sentry.UserFeedback userFeedback) { }
[System.Obsolete("Sentry client should not be explicitly disposed of. This method will be removed i" +
"n version 4.")]
public void Dispose() { }
public System.Threading.Tasks.Task FlushAsync(System.TimeSpan timeout) { }
}
Expand Down
2 changes: 0 additions & 2 deletions test/Sentry.Tests/ApiApprovalTests.Run.Net4_8.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,8 +481,6 @@ namespace Sentry
public void CaptureTransaction(Sentry.Transaction transaction) { }
public void CaptureTransaction(Sentry.Transaction transaction, Sentry.Hint? hint) { }
public void CaptureUserFeedback(Sentry.UserFeedback userFeedback) { }
[System.Obsolete("Sentry client should not be explicitly disposed of. This method will be removed i" +
"n version 4.")]
public void Dispose() { }
public System.Threading.Tasks.Task FlushAsync(System.TimeSpan timeout) { }
}
Expand Down
Loading