-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Metrics.Set
now accepts string
as value
#3092
Conversation
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3092 +/- ##
==========================================
- Coverage 76.53% 76.11% -0.42%
==========================================
Files 355 357 +2
Lines 13381 13465 +84
Branches 2656 2669 +13
==========================================
+ Hits 10241 10249 +8
- Misses 2460 2533 +73
- Partials 680 683 +3 ☔ View full report in Codecov by Sentry. |
@bitsandfoxes did you see System.IO.Hashing.Crc32? I guess that comes with a dependency on the System.IO.Hashing NuGet package... |
Yes. Not wanting to take on the dependency is the reason why we're vendoring it in. |
From the updated dev docs: https://develop.sentry.dev/sdk/metrics/#sets
Set should accept strings as value
.With this PR we're vendoring in part of force's Crc32.NET implementation because there is not anything built-in that I could find.