Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refrain from adding Sentry to global usings #3109

Closed
wants to merge 2 commits into from

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Feb 2, 2024

Fixes #3105

Keeping this a contingency if we do need to roll back the change.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66920cd) 76.86% compared to head (71c4f00) 76.88%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3109      +/-   ##
==========================================
+ Coverage   76.86%   76.88%   +0.01%     
==========================================
  Files         357      357              
  Lines       13466    13466              
  Branches     2671     2671              
==========================================
+ Hits        10351    10353       +2     
+ Misses       2435     2434       -1     
+ Partials      680      679       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitsandfoxes bitsandfoxes marked this pull request as draft February 6, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Sentry to global usings breaks compilation all over the place in 4.0.0
1 participant