Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: No service for type 'Sentry.IHub' has been registered #3129

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Fix: No service for type 'Sentry.IHub' has been registered #3129

merged 7 commits into from
Feb 7, 2024

Conversation

jamescrosswell
Copy link
Collaborator

Resolves #3127

@jamescrosswell jamescrosswell marked this pull request as ready for review February 7, 2024 11:43
bitsandfoxes
bitsandfoxes approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any integration tests, do we? I feel like we should start having some.

@jamescrosswell jamescrosswell merged commit c8330f1 into main Feb 7, 2024
12 of 13 checks passed
@jamescrosswell jamescrosswell deleted the fix/no-service-type branch February 7, 2024 21:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- No service for type 'Sentry.IHub' has been registered ([#3129](https://github.com/getsentry/sentry-dotnet/pull/3129))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against ffec669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitsandfoxes bitsandfoxes bitsandfoxes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No service for type 'Sentry.IHub' has been registered
2 participants
@jamescrosswell @bitsandfoxes