Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Tracing for SentryHttpMessageHandler with no active transaction #3367

Merged
merged 4 commits into from
May 14, 2024

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented May 14, 2024

Reason being: Requests should creating a transaction on their own is by design to protect users' transaction quota.

@bitsandfoxes bitsandfoxes merged commit f22c2d4 into main May 14, 2024
16 of 17 checks passed
@bitsandfoxes bitsandfoxes deleted the revert/auto-transaction-creation branch May 14, 2024 12:05
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Tracing for `SentryHttpMessageHandler` with no active transaction ([#3367](https://github.com/getsentry/sentry-dotnet/pull/3367))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against f51b80a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants