Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fiber integration #273

Closed
wants to merge 8 commits into from
Closed

Add Fiber integration #273

wants to merge 8 commits into from

Conversation

arsmn
Copy link

@arsmn arsmn commented Aug 23, 2020

Fiber integration

@arsmn
Copy link
Author

arsmn commented Sep 19, 2020

@rhcarvalho

@rhcarvalho
Copy link
Contributor

@arsmn thanks for the contribution. Sorry we haven't had the bandwidth to review this yet.
On a high level I expect this is pretty much the same as the fasthttp integration with types adapted to match fiber's.

I'll have a look at this and Buffalo (#196) in the coming weeks, perhaps start moving integrations off into their own modules to avoid an ever increasing list of deps in the main go.mod file.

@rhcarvalho rhcarvalho added this to the v0.8.0 milestone Sep 23, 2020
@akshaybabloo
Copy link

@rhcarvalho gentle ping

@anistark
Copy link

@rhcarvalho Can we please merge this ?

@th0th
Copy link

th0th commented May 6, 2021

Any updates on this? 💐

@alizaya
Copy link

alizaya commented Aug 3, 2021

any news?

@ciazhar
Copy link

ciazhar commented Sep 27, 2021

@rhcarvalho any update ?

@efectn
Copy link

efectn commented Oct 4, 2021

Any update?

@pateljoel
Copy link

Would be nice if this was merged in with official support for Fiber and Sentry.
Are there any issues @rhcarvalho?

@DuginKim
Copy link

any update?
plz

@NoobTW
Copy link

NoobTW commented Nov 7, 2021

Ping

@rodrigoodhin
Copy link

any update?
plz

@fcarvalhido
Copy link

Ping and Pong, please.

@DuginKim
Copy link

not yet?

@DuginKim
Copy link

DuginKim commented Jan 4, 2022

not yet2?

@rhcarvalho @kamilogorek @benvinegar

@sebastianbuechler
Copy link

@arsmn thanks for the contribution. Sorry we haven't had the bandwidth to review this yet. On a high level I expect this is pretty much the same as the fasthttp integration with types adapted to match fiber's.

I'll have a look at this and Buffalo (#196) in the coming weeks, perhaps start moving integrations off into their own modules to avoid an ever increasing list of deps in the main go.mod file.

This is open for 1.5 years now. Is this still on the road map?

@efectn
Copy link

efectn commented Jan 12, 2022

I think @arsmn should create PR under the https://github.com/gofiber/contrib.

@arsmn
Copy link
Author

arsmn commented Jan 12, 2022

Fiber integration is now available https://github.com/gofiber/contrib/tree/main/fibersentry
Thank you all

@cleptric
Copy link
Member

Hey @arsmn
Are you still interested in getting this merged?

@cleptric cleptric linked an issue Oct 30, 2022 that may be closed by this pull request
@robd003
Copy link

robd003 commented Dec 20, 2022

Hey @cleptric & @arsmn any chance we could get this merged in? I'd love to have Sentry officially support this!

@cleptric
Copy link
Member

cleptric commented Jan 9, 2023

@robd003 Adding a Fiber integration is definitely on our road map, but I can't provide you with an ETA when this may land.

@alfawal
Copy link

alfawal commented Feb 21, 2024

@cleptric Kind reminder 🙏🏻

@cleptric cleptric requested a review from ribice March 14, 2024 11:39
@ribice ribice mentioned this pull request Mar 18, 2024
@vaind
Copy link
Collaborator

vaind commented Mar 26, 2024

Updated to work with the latest main branch in #795

@vaind vaind closed this Mar 26, 2024
@vaind
Copy link
Collaborator

vaind commented Mar 26, 2024

Thanks @arsmn for the contribution and sorry it took so long to get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Fiber