docs: Fix mentions to 'all events' #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the examples and accompanying documentation were written, 'all events' meant 'error events'. With transactions added to the SDK, BeforeSend is only applied to error events while all EventProcessor functions (on client, scope or global) are applied to all outgoing events (errors and transactions).
AbhiPrasad
approved these changes
May 19, 2021
Comment on lines
+83
to
+85
| // Solution 2 (use custom integration, which will be | ||
| // applied to all events, and can be extracted as a | ||
| // separate utility and reused across projects): |
There was a problem hiding this comment.
nit: Think this flows better
Suggested change
| // Solution 2 (use custom integration, which will be | |
| // applied to all events, and can be extracted as a | |
| // separate utility and reused across projects): | |
| // Solution 2 (use custom integration, which will be | |
| // applied to all events, can be extracted as a | |
| // separate utility, and reused across projects): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the examples and accompanying documentation were written, 'all events' meant 'error events'.
With transactions added to the SDK,
BeforeSendis only applied to error events while allEventProcessorfunctions (on client, scope or global) are applied to all outgoing events (errors and transactions).