Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Improve isSentryRequestUrl #636

Merged
merged 4 commits into from
May 8, 2023
Merged

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented May 7, 2023

This is a follow-up on #632, to add better error handling as well as a better comparison of the span attribute URL.

Has to be merged after #631.

otel/internal/utils/sentryrequest.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.07 ⚠️

Comparison is base (94e8e06) 79.66% compared to head (08aaeec) 79.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
- Coverage   79.66%   79.60%   -0.07%     
==========================================
  Files          38       38              
  Lines        3885     3888       +3     
==========================================
  Hits         3095     3095              
- Misses        681      683       +2     
- Partials      109      110       +1     
Impacted Files Coverage Δ
otel/internal/utils/sentryrequest.go 56.00% <40.00%> (-7.64%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cleptric cleptric merged commit ce90464 into master May 8, 2023
@cleptric cleptric deleted the improve-is-sentry-request branch May 8, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants