Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentrygin: Add TransactionNameGenerator option #687

Closed
wants to merge 1 commit into from
Closed

Sentrygin: Add TransactionNameGenerator option #687

wants to merge 1 commit into from

Conversation

janwytze
Copy link

@janwytze janwytze commented Aug 4, 2023

We would like to use c.Request.RequestURI in the transaction name instead of c.Request.URL.Path, but the transaction name is currently hard-coded. With the transactionNameGenerator a transaction name can be configured.

@janwytze janwytze changed the title Sentrygin: Add TransactionNameHandlerGenerator option Sentrygin: Add TransactionNameGenerator option Aug 4, 2023
@cleptric
Copy link
Member

cleptric commented Aug 9, 2023

For now, we'll move forward with #675 instead, where the new default is c.FullPath().

You can already overwrite the transaction name today, some options include using BeforeSendTransaction, receiving the transaction from the ctx transaction := sentry.TransactionFromContext(ctx) and setting its name transaction.Name = 'custom-name' or an event processor (called integrations).

@cleptric cleptric closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants